Agreement error in the UI

oliver.gramberg · March 18, 2022, 8:00pm

Description

Foundry376/Mailspring/blob/a3aecf628a77d51badaa7a8860acffab0f1afcb3/app/internal_packages/message-list/lib/message-list-hidden-messages-toggle.tsx

import React from 'react';
import { localized, Actions, MessageStore, FocusedPerspectiveStore } from 'mailspring-exports';

export class MessageListHiddenMessagesToggle extends React.Component {
  static displayName = 'MessageListHiddenMessagesToggle';

  static containerRequired: false;

  _unlisten?: () => void;

  state = {
    numberOfHiddenItems: MessageStore.numberOfHiddenItems(),
  };

  componentDidMount() {
    this._unlisten = MessageStore.listen(() => {
      this.setState({
        numberOfHiddenItems: MessageStore.numberOfHiddenItems(),
      });
    });

This file has been truncated. show original

50c50
<           `%@ messages in this thread are hidden because it was moved to trash or spam.`,
>           `%@ messages in this thread are hidden because they were moved to trash or spam.`,

Phylu · March 31, 2022, 5:59am

I am not sure about this change. It seems that the it refers to the thread and not to the messages. So for me this sentence seems correct even if it could be misunderstood. However, I am no English native speaker.

oliver.gramberg · March 31, 2022, 6:45am

@Phylu Good point; let me provide more context. Assume I have three messages in a thread, two of which have been deleted, the remaining one is in the inbox. The message displayed by Mailspring is, “2 messages in this thread are hidden because it was moved to trash or spam.”

If not all messages that belong to a thread have been deleted, I do not regard the thread itself to have been deleted. So, IMHO,

either something about the detection of which messages belong to a thread is faulty,
or the message displayed should refer to e-mail messages, not the thread, hence plural.

Please also compare source lines 50 and 55 to lines 39 and 44. If not plural on line 50, then why plural on line 39?

Phylu · March 31, 2022, 4:13pm

@oliver.gramberg That makes total sense now

If you want, you can simply open a Pull Request on GitHub adressing the issue. You will just need to make sure that you replace the string in all translation files as well. But this should be easily possible using search and replace.

If you don’t feel comfortable doing this, I can also implement the change.

oliver.gramberg · April 1, 2022, 11:52am

@Phylu I’d prefer if you’d do it. It feels like you know very well what you are talking about and the universe’s resources are more efficiently used this way … thanks.

Phylu · April 1, 2022, 8:36pm

Thanks for the info. I will implement it.

I don’t want to abuse this universe’s resources.

Phylu · April 3, 2022, 12:55pm

@oliver.gramberg This is tackled in: https://github.com/Foundry376/Mailspring/pull/2385

system · May 3, 2022, 12:55pm

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.