Cannot add image to signature when not using Mailspring ID

Description

When mailspring is installed without using the option of a Mailspring ID, it is not possible to add an image to the signature.

To Reproduce…

Steps to reproduce the behavior:

  1. Install Mailspring without connecting with a mailspring ID
  2. Add an account and create a signature for it
  3. Add an image to the signature
  4. Verify getting an error:

Sorry, we couldn’t save your signature image to Mailspring’s servers. Please try again. (Error: makeRequest: A Mailspring identity is required.)

Expected Behavior

It is possible to add an image to the signature; this is not dependent on a Mailspring ID.

Screenshots

Setup

  • OS and Version: Pop!_OS 20.10
    • Installation Method: snap
  • Mailspring Version: 1.9.1

Oh, interesting! This must have slipped by testing.

Ahh good catch! I’ll see if we can hide the signature image upload option in the next update - we need to tie your signature to your mailspring ID to be able to delete it in compliance with GDPR if you ask for your data to be removed, so I don’t think we can enable this if you opt-out.

Should be resolved by Disable signature image upload if you are signed out of Mailspring ID · Foundry376/Mailspring@dae0085 · GitHub, thanks!

2 Likes

@bengotow I’ve moved this to #bugs:resolved and marked it as #resolved accordingly. :slight_smile:

1 Like