Dark Theme on Message Optional/Poor text rendering in dark theme

[CodeMouse92 (Jason C. McDonald)]

There seem to be several problems with email rendering on dark themes:

512×512 63.1 KB

Mailspring 112 - Windows 10 x64 with the theme installed at the installation, named DARK I had a display problem with the mail Newletter Netflix. See the screenshots: With DARK [theme dark] With theme by default [theme par defaut 2018-02-01_11-40-13] (Originally posted by franco27 on GitHub.)

Emojis get wrong color in dark theme

Description When composing an email, emojis appear as they should (img 1). However, when receiving an email with emojis, they get inverted colors (img 2), which makes them… weird… To Reproduce… Steps to reproduce the behavior: Setup dark theme Send an email with emojis in it. Open that email afterwards. The emojis are the wrong color. Expected Behavior Emojis should always have the same color regardless of theme. Screenshots [image] Setup OS and Version: Windows 10 Mailspring Version: 1…

512×512 63.1 KB

As @bengotow already mentioned above, it requires quite some trickery. The embedded <style>...</style> tag cannot be overridden from within css the way Mailspring is implemented right now. However, if the specific goal is to solve the problem of dark text in dark themes, webkit filters can be used. I’ll try to explain the rationale of my approach. Inside the .ignore-in-parent-frame of email-frame.less, I did the following: Set the default text color inside #inbox-html-wrapper to something dar…

I think we need to reconsider dark mode on emails, or else make it a separate option.