The 1.19.1 release is incomplete

Installation & Packaging
1

Multiple issues with the 1.19.1 release, i found while trying to package the flatpak for it:

  • The app/package-lock.json file was not updated. This file is used to generate the sources of the flatpak.
    • The version is still 1.19.0.
    • electron is still pinned to 39.2.7, a missmatch with the root package-lock.json.
  • The app/build/resources/linux/mailspring.appdata.xml.in file was not updated.
    • The release tag for 1.19.1 is missing.
    • Not an issue but related: Each release tag should provide a changelog. You do not have to duplicate it, a link to it is sufficient.

I try to package it as-is, but it will still show up as 1.19.0 in stores. After this is fixed, a retag or point release would be nice.

Closing (flatpak) Mailspring fails and eats all CPU
2

Hey @LinusDierheimer thanks for reporting this, this is definitely my bad. I’ll get a proper checklist created in the repo documenting release steps so I don’t forget this again.

I’ve pushed a commit fixing the metadata 1.19.1 - fix release metadata · Foundry376/Mailspring@bb8bc01 · GitHub, and I’ll see if we can do a point release in the next day or two to fix this properly, I expect that there will be a few misc bugs to fix tomorrow from the Electron 39=>41 upgrade.

Thanks for your help with the Flatpak I really appreciate it -