Specimen
(Specimen)
December 1, 2022, 4:18pm
#1
Description
Time is incorrectly displayed in emails that were received between midnight and 1:00 in the 24-hour format.
They should appear as 00:xx and not 24:xx.
To Reproduce…
Steps to reproduce the behavior:
1 - Use the 24 hour format
2 - Receive an email between 00:00 and 00:59.
3 - Check the email date and time in your inbox
Expected Behavior
The time should appear as 00:xx and not 24:xx (check screenshot)
Screenshots
Setup
OS and Version: Windows 11 22H2
Mailspring Version: 1.10.7
Additional Context
glenn2223
(Glenn)
December 2, 2022, 10:34pm
#2
Thanks for pointing this out, looks like the JS code for international datetime didn’t quite work the way I expected. There’s a PR that fixes this issue - originally fixing a 12pm issue, but will fix this too - just waiting for it to be merged.
Foundry376:master
← glenn2223:invalid-time-12pm-community#5938
opened 10:27PM - 23 Nov 22 UTC
12pm is now shown instead of 0pm
![image](https://user-images.githubuserconte… nt.com/33450392/203656198-e87bab5c-7f0b-4a6c-8241-c4f5366188d7.png)
---
Not I needed to use `h23` instead of `h24` else midnight would have been shown as `24:01` - or similar
![image](https://user-images.githubusercontent.com/33450392/203656514-502dee9b-9efd-4cb6-9fcf-c2cd7d485376.png)
1 Like
Specimen
(Specimen)
December 2, 2022, 10:46pm
#3
No problem and thanks for fixing!